Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to master branch #1

Open
wants to merge 6,344 commits into
base: master-v1.4.2
Choose a base branch
from
Open

Conversation

jkim485
Copy link

@jkim485 jkim485 commented Jun 30, 2017

What? Why?

Fix # .

Changes proposed in this pull request:

  • a
  • b

Checks

  • Runs on Heroku.
  • Follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Follows the Google Style Guide.
  • Make sure your commit messages end with a Signed-off-by string (this line
    can be automatically added by git if you run the git-commit command with
    the -s option)
  • If this is a feature, the PR is to rc. If this is a bug fix, the PR is to
    hotfix.

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. GifGrabber.

Notify reviewers

Read our Pull request merging
policy
. If you are part of the
cBioPortal organization, notify the approprate team (remove inappropriate):

@cBioPortal/frontend
@cBioPortal/backend
@cBioPortal/devops

If you are not part of the cBioPortal organization look at who worked on the
file before you. Please use git blame <filename> to determine that
and notify them here:

haynescd and others added 30 commits January 29, 2024 14:03
Adds integration testing to sonarcube analysis.
Fixes some sonarcube issues that were raised
Pulls fixes made in Demo 6.0.0
🔒 Add 401 response when not authorized exception is thrown instead of redirect
hweej and others added 30 commits October 7, 2024 17:22
…esults

Add resource-data-all endpoint and MyBatis SQL methods
…ce-data

Fix cache annotation resource data
…lter-chain-ordering

🔒 Update Default Filter Chain Ordering for Spring Security
* Add Chromoscope News
* Add isDynamic field to Virtual Study in Session Service

* Query sample IDs using Virtual Study View Filters is it's of dynamic type

* Rename boolean varialbe name isDynamic -> dynamic

* Refactor dynamic virtual study population

Extract smaller functions

* Fix code smells discovered by sonarlint

- Use the constructor dep. injection
- return value withou assigning it to a variable

* Add web mvc test for fetching static and dynamic virtual studies
* Add ICI note to chromoscope news
---------

Co-authored-by: Ino de Bruijn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.